Skip to content

Add default codeowners to /src/symtab2gb/ and /src/json-symtab-language/ #8087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

thomasspriggs
Copy link
Contributor

The existing lines in the CODEOWNERS file overrides the default code owners, leaving Martin as the sole code owner. Adding the default code owners to the list should make it more straight forward to maintain these areas.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The existing lines in the `CODEOWNERS` file override the default
codeowners, leaving Martin as the sole code owner. Adding the default
codeowners to the list should make it more straight forward to maintain
these areas.
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d01fa33) 79.09% compared to head (3b5096a) 79.09%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8087   +/-   ##
========================================
  Coverage    79.09%   79.09%           
========================================
  Files         1701     1701           
  Lines       196625   196625           
========================================
  Hits        155527   155527           
  Misses       41098    41098           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening merged commit 2228fe9 into diffblue:develop Nov 28, 2023
@thomasspriggs thomasspriggs mentioned this pull request Nov 28, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants