-
Notifications
You must be signed in to change notification settings - Fork 273
Remove util_make_unique #8032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove util_make_unique #8032
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #8032 +/- ##
===========================================
+ Coverage 79.09% 79.10% +0.01%
===========================================
Files 1699 1698 -1
Lines 196512 196502 -10
===========================================
+ Hits 155428 155440 +12
+ Misses 41084 41062 -22 ☔ View full report in Codecov by Sentry. |
With the move to C++ 17 we can use std::make_unique instead.
c17285c
to
096f454
Compare
@martin-cs This seems to need your review due to a change in |
That should be resolved by the addition of extra code owners in #8087 I think we still need review from one of @qinheping @feliperodri or @remi-delmas-3000 due to the update in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in goto/synthesizer
LGTM.
With the move to C++ 17 we can use std::make_unique instead.