Skip to content

Remove util_make_unique #8032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

tautschnig
Copy link
Collaborator

With the move to C++ 17 we can use std::make_unique instead.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (7979553) 79.09% compared to head (c17285c) 79.10%.
Report is 1 commits behind head on develop.

❗ Current head c17285c differs from pull request most recent head 096f454. Consider uploading reports for the commit 096f454 to get more accurate results

Files Patch % Lines
src/goto-instrument/cover.cpp 80.00% 3 Missing ⚠️
jbmc/src/jbmc/jbmc_parse_options.cpp 66.66% 2 Missing ⚠️
src/analyses/invariant_propagation.cpp 0.00% 2 Missing ⚠️
jbmc/src/java_bytecode/java_bytecode_language.h 0.00% 1 Missing ⚠️
src/analyses/goto_rw.cpp 50.00% 1 Missing ⚠️
...lyses/variable-sensitivity/abstract_value_object.h 0.00% 1 Missing ⚠️
src/ansi-c/ansi_c_language.h 0.00% 1 Missing ⚠️
src/cbmc/cbmc_parse_options.cpp 83.33% 1 Missing ⚠️
src/cpp/cpp_language.h 0.00% 1 Missing ⚠️
src/goto-analyzer/build_analyzer.cpp 93.75% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8032      +/-   ##
===========================================
+ Coverage    79.09%   79.10%   +0.01%     
===========================================
  Files         1699     1698       -1     
  Lines       196512   196502      -10     
===========================================
+ Hits        155428   155440      +12     
+ Misses       41084    41062      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

With the move to C++ 17 we can use std::make_unique instead.
@thomasspriggs
Copy link
Contributor

@martin-cs This seems to need your review due to a change in /src/json-symtab-language/

@thomasspriggs
Copy link
Contributor

@martin-cs This seems to need your review due to a change in /src/json-symtab-language/

That should be resolved by the addition of extra code owners in #8087

I think we still need review from one of @qinheping @feliperodri or @remi-delmas-3000 due to the update in src/goto-synthesizer/

Copy link
Collaborator

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in goto/synthesizer LGTM.

@feliperodri feliperodri removed their assignment Nov 28, 2023
@kroening kroening merged commit 6475b3c into diffblue:develop Nov 28, 2023
@tautschnig tautschnig deleted the cleanup/make_unique branch November 28, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.