Skip to content

Update CaDiCaL from 1.4.1 to 1.5.3 #7734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

tautschnig
Copy link
Collaborator

Maintenance update to the latest release, no notable performance differences expected or observed.

Also patch out the comparison of this against NULL, which we reported upstream as arminbiere/cadical#54.

Fixes: #7725

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d5e13f1) 78.54% compared to head (f9cd820) 78.54%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7734   +/-   ##
========================================
  Coverage    78.54%   78.54%           
========================================
  Files         1688     1688           
  Lines       193001   193001           
========================================
  Hits        151599   151599           
  Misses       41402    41402           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Maintenance update to the latest release, no notable performance
differences expected or observed.

Also patch out the comparison of `this` against `NULL`, which we
reported upstream as arminbiere/cadical#54.

Fixes: diffblue#7725
@kroening kroening merged commit af598d9 into diffblue:develop Jun 6, 2023
@tautschnig tautschnig deleted the cadical-1.5.3 branch June 6, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling with cadical needs a flag to turn off optional compiler warnings
7 participants