Skip to content

Compiling with cadical needs a flag to turn off optional compiler warnings #7725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
martinlester opened this issue May 22, 2023 · 1 comment · Fixed by #7734
Closed

Compiling with cadical needs a flag to turn off optional compiler warnings #7725

martinlester opened this issue May 22, 2023 · 1 comment · Fixed by #7734
Labels
pending merge

Comments

@martinlester
Copy link

CBMC version: 5.83.0
Operating system: Debian 12
Exact command line resulting in the issue: cmake -S . -Bbuild -Dsat_impl="cadical" ; cmake --build build
What behaviour did you expect: Successful compilation with cadical as SAT solver.
What happened instead: Compilation error.

Lots of errors like this:

solver.cpp:259:3: error: ‘nonnull’ argument ‘this’ compared to NULL [-Werror=nonnull-compare]

I can work around this by configuring with something like this instead:

cmake -S . -Bbuild -DCMAKE_CXX_FLAGS="-Wnonnull-compare"
@martinlester martinlester changed the title Compiling with cadical needs Compiling with cadical needs a flag to turn off optional compiler warnings May 22, 2023
@tautschnig tautschnig mentioned this issue May 23, 2023
Closed
@tautschnig
Copy link
Collaborator

I have filed an issue against CaDiCaL to get this fixed upstream.

tautschnig added a commit to tautschnig/cbmc that referenced this issue May 29, 2023
@tautschnig
Update CaDiCaL from 1.4.1 to 1.5.3
988621a 
Maintenance update to the latest release, no notable performance
differences expected or observed.

Also patch out the comparison of `this` against `NULL`, which we
reported upstream as arminbiere/cadical#54.

Fixes: diffblue#7725
@tautschnig tautschnig mentioned this issue May 29, 2023
Merged
4 tasks
tautschnig added a commit to tautschnig/cbmc that referenced this issue May 29, 2023
@tautschnig
Update CaDiCaL from 1.4.1 to 1.5.3
f9cd820 
Maintenance update to the latest release, no notable performance
differences expected or observed.

Also patch out the comparison of `this` against `NULL`, which we
reported upstream as arminbiere/cadical#54.

Fixes: diffblue#7725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CaDiCaL from 1.4.1 to 1.5.3 tautschnig/cbmc
2 participants
@tautschnig @martinlester