Skip to content

Symex: Simplify left-hand side #7700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

With #7622 we may have syntactically changed the type on the right-hand side via simplification. To maintain syntactic type equality we need to apply simplifications on the left-hand side as well. See https://github.com/awslabs/aws-c-common/actions/runs/4822448417 for an example where this failed after #7622.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig added bugfix aws Bugs or features of importance to AWS CBMC users labels May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (cafbcc4) 78.50% compared to head (dec8c60) 78.48%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7700      +/-   ##
===========================================
- Coverage    78.50%   78.48%   -0.02%     
===========================================
  Files         1674     1674              
  Lines       191954   191956       +2     
===========================================
- Hits        150698   150666      -32     
- Misses       41256    41290      +34     
Impacted Files Coverage Δ
src/goto-symex/goto_symex_state.cpp 91.86% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@peterschrammel peterschrammel removed their assignment May 5, 2023
@peterschrammel
Copy link
Member

Is there a test that exhibits the problem?

@tautschnig tautschnig assigned tautschnig and unassigned kroening May 5, 2023
@tautschnig
Copy link
Collaborator Author

Is there a test that exhibits the problem?

I will try to craft one (the aws-c-common example is too big a code base for a regression test).

@tautschnig tautschnig force-pushed the bugfixes/array-size-followup branch from 23853fe to f0ac086 Compare May 8, 2023 13:03
With diffblue#7622 we may have syntactically changed the type on the right-hand
side via simplification. To maintain syntactic type equality we need to
apply simplifications on the left-hand side as well. See
https://github.com/awslabs/aws-c-common/actions/runs/4822448417 for an
example where this failed after diffblue#7622.
@tautschnig tautschnig force-pushed the bugfixes/array-size-followup branch from f0ac086 to dec8c60 Compare May 8, 2023 21:39
@tautschnig tautschnig merged commit e7787ad into diffblue:develop May 9, 2023
@tautschnig tautschnig deleted the bugfixes/array-size-followup branch May 9, 2023 05:56
tautschnig added a commit to awslabs/aws-c-common that referenced this pull request May 15, 2023
This reverts commit 9848a8c ("Pin CBMC
version to 5.81.0", PR #1022): CBMC 5.83.0 includes
diffblue/cbmc#7700, which fixes the problem
spotted by aws-c-common's tests.
graebm pushed a commit to awslabs/aws-c-common that referenced this pull request May 15, 2023
This reverts commit 9848a8c ("Pin CBMC
version to 5.81.0", PR #1022): CBMC 5.83.0 includes
diffblue/cbmc#7700, which fixes the problem
spotted by aws-c-common's tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users aws-high bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants