Simplify array size expressions #7622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symbolic execution may be able to replace symbolic sizes by constants, but even the symbolic size might include a type cast (for examples, ones arising from uses of havoc_slice). Simplify those expressions to avoid appearance of almost-a-constant expressions.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7622 +/- ##
===========================================
+ Coverage 78.13% 78.51% +0.37%
===========================================
Files 1671 1671
Lines 191845 191851 +6
===========================================
+ Hits 149905 150624 +719
+ Misses 41940 41227 -713
... and 34 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
TGWDB
approved these changes
Mar 27, 2023
peterschrammel
approved these changes
Mar 28, 2023
It seems that |
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
May 4, 2023
With diffblue#7622 we may have syntactically changed the type on the right-hand side via simplification. To maintain syntactic type equality we need to apply simplifications on the left-hand side as well. See https://github.com/awslabs/aws-c-common/actions/runs/4822448417 for an example where this failed after diffblue#7622.
3 tasks
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
May 8, 2023
With diffblue#7622 we may have syntactically changed the type on the right-hand side via simplification. To maintain syntactic type equality we need to apply simplifications on the left-hand side as well. See https://github.com/awslabs/aws-c-common/actions/runs/4822448417 for an example where this failed after diffblue#7622.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
May 8, 2023
With diffblue#7622 we may have syntactically changed the type on the right-hand side via simplification. To maintain syntactic type equality we need to apply simplifications on the left-hand side as well. See https://github.com/awslabs/aws-c-common/actions/runs/4822448417 for an example where this failed after diffblue#7622.
qinheping
pushed a commit
to remi-delmas-3000/cbmc
that referenced
this pull request
May 19, 2023
With diffblue#7622 we may have syntactically changed the type on the right-hand side via simplification. To maintain syntactic type equality we need to apply simplifications on the left-hand side as well. See https://github.com/awslabs/aws-c-common/actions/runs/4822448417 for an example where this failed after diffblue#7622.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbolic execution may be able to replace symbolic sizes by constants, but even the symbolic size might include a type cast (for examples, ones arising from uses of havoc_slice). Simplify those expressions to avoid appearance of almost-a-constant expressions.