-
Notifications
You must be signed in to change notification settings - Fork 273
Factor out re-creating __CPROVER_initialize into a function #7680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0780955
to
834bf8a
Compare
834bf8a
to
218fc13
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7680 +/- ##
===========================================
- Coverage 78.55% 78.55% -0.01%
===========================================
Files 1686 1686
Lines 192923 192897 -26
===========================================
- Hits 151552 151526 -26
Misses 41371 41371
☔ View full report in Codecov by Sentry. |
218fc13
to
44cfcac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
src/linking/static_lifetime_init.cpp
Outdated
goto_modelt &goto_model, | ||
message_handlert &message_handler) | ||
{ | ||
if(goto_model.unload(INITIALIZE_FUNCTION) != 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be sensible to make it a precondition that the initialize function exists, as opposed to doing a silent no-op?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now changed the usage model according to your suggestion.
This avoids repeating the almost-same code in several places, and moves a helper that is not DFCC-specific to the global context.
44cfcac
to
1909f3e
Compare
This avoids repeating the almost-same code in several places, and moves
a helper that is not DFCC-specific to the global context.
The first two commits are #7678 and #7679.