Skip to content

Decouple is_fresh from code_contractst #7679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2023

Conversation

tautschnig
Copy link
Collaborator

It really just needs a goto model, and otherwise has no dependency on code contracts. Also consistently use message handlers, not messaget.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 96.00% and project coverage change: -0.01 ⚠️

Comparison is base (bce472f) 78.51% compared to head (9777e00) 78.51%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7679      +/-   ##
===========================================
- Coverage    78.51%   78.51%   -0.01%     
===========================================
  Files         1674     1674              
  Lines       191946   191943       -3     
===========================================
- Hits        150715   150711       -4     
- Misses       41231    41232       +1     
Impacted Files Coverage Δ
src/goto-instrument/contracts/contracts.h 100.00% <ø> (ø)
...rc/goto-instrument/contracts/memory_predicates.cpp 84.97% <95.00%> (-0.60%) ⬇️
src/goto-instrument/contracts/contracts.cpp 94.79% <100.00%> (-0.02%) ⬇️
src/goto-instrument/contracts/memory_predicates.h 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@feliperodri feliperodri added aws Bugs or features of importance to AWS CBMC users Code Contracts Function and loop contracts labels May 1, 2023
It really just needs a goto model, and otherwise has no dependency on
code contracts. Also consistently use message handlers, not messaget.
@tautschnig tautschnig merged commit 862d2a1 into diffblue:develop May 5, 2023
@tautschnig tautschnig deleted the cleanup/is_fresh branch May 5, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users blocker Code Contracts Function and loop contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants