Skip to content

Cleanup GitHub actions #7480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 16, 2023
+61 −58
Merged

Cleanup GitHub actions #7480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af7033e
Note down expected CI execution times
tautschnig Jan 16, 2023
12d25a9
GitHub actions: avoid trashing caches
tautschnig Jan 16, 2023
09813fa
GitHub actions: whitespace cleanup
tautschnig Jan 16, 2023
97dcc54
GitHub actions: unify build commands
tautschnig Jan 16, 2023
2964edf
Run GitHub pull request checks on push to develop
tautschnig Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/build-and-test-Linux.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:
- '**'

jobs:
# This job takes approximately 18 minutes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that these are informational only, but how are we going to track any changes to these numbers?

Or is the plan to be more laid back and only update them if we casually observe any change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I was thinking keep this informal, but maybe we should go a little further and do actual checks? Don't know, I'm open to suggestions.

CompileLinux:
runs-on: ubuntu-20.04
steps:
Expand All @@ -19,18 +20,18 @@ jobs:
DEBIAN_FRONTEND: noninteractive
run: |
sudo apt-get update
sudo apt-get install --no-install-recommends -y g++ flex bison cmake ninja-build maven jq libxml2-utils dpkg-dev ccache
sudo apt-get install --no-install-recommends -y clang-10 clang++-10 flex bison cmake ninja-build maven jq libxml2-utils dpkg-dev ccache
sudo apt-get install --no-install-recommends -y libssl-dev libelf-dev libudev-dev libpci-dev libiberty-dev autoconf
sudo apt-get install --no-install-recommends -y gawk jq

- name: Prepare ccache
uses: actions/cache@v3
with:
path: .ccache
key: ${{ runner.os }}-20.04-make-${{ github.ref }}-${{ github.sha }}-KERNEL
key: ${{ runner.os }}-20.04-make-clang-${{ github.ref }}-${{ github.sha }}-KERNEL
restore-keys: |
${{ runner.os }}-20.04-make-${{ github.ref }}
${{ runner.os }}-20.04-make
${{ runner.os }}-20.04-make-clang-${{ github.ref }}
${{ runner.os }}-20.04-make-clang
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
Expand All @@ -40,7 +41,7 @@ jobs:
- name: Build CBMC tools
run: |
make -C src minisat2-download
make -C src CXX='ccache /usr/bin/g++' cbmc.dir goto-cc.dir goto-diff.dir -j2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the compiler change here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to make sure we can actually use the compiler cache (and don't trash it by putting a different configuration in there).

make -C src CXX='ccache /usr/bin/clang++' cbmc.dir goto-cc.dir goto-diff.dir -j2
- name: Print ccache stats
run: ccache -s

Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/build-and-test-Xen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
branches: [ develop ]

jobs:
# This job takes approximately 33 minutes
CompileXen:
runs-on: ubuntu-20.04
steps:
Expand All @@ -20,16 +21,16 @@ jobs:
sudo apt-get update
sudo apt-get install --no-install-recommends -y build-essential git flex bison software-properties-common curl python
sudo apt-get install --no-install-recommends -y bin86 gdb bcc liblzma-dev python-dev gettext iasl uuid-dev libncurses5-dev libncursesw5-dev pkg-config
sudo apt-get install --no-install-recommends -y libgtk2.0-dev libyajl-dev time ccache
sudo apt-get install --no-install-recommends -y libgtk2.0-dev libyajl-dev time ccache clang-10 clang++-10

- name: Prepare ccache
uses: actions/cache@v3
with:
path: .ccache
key: ${{ runner.os }}-20.04-make-${{ github.ref }}-${{ github.sha }}-XEN
key: ${{ runner.os }}-20.04-make-clang-${{ github.ref }}-${{ github.sha }}-XEN
restore-keys: |
${{ runner.os }}-20.04-make-${{ github.ref }}
${{ runner.os }}-20.04-make
${{ runner.os }}-20.04-make-clang-${{ github.ref }}
${{ runner.os }}-20.04-make-clang
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
Expand All @@ -39,7 +40,7 @@ jobs:
- name: Build CBMC tools
run: |
make -C src minisat2-download
make -C src CXX='ccache /usr/bin/g++' cbmc.dir goto-cc.dir goto-diff.dir -j2
make -C src CXX='ccache /usr/bin/clang++' cbmc.dir goto-cc.dir goto-diff.dir -j2
- name: Print ccache stats
run: ccache -s

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
branches: [ develop ]

jobs:
# This job takes approximately 82 minutes
analyze:
name: Analyze
runs-on: ubuntu-latest
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/csmith.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
branches: [ develop ]

jobs:
# This job takes approximately 18 minutes
run-10-random-tests:
runs-on: ubuntu-20.04
steps:
Expand All @@ -17,17 +18,17 @@ jobs:
# user input
DEBIAN_FRONTEND: noninteractive
run: |
sudo apt-get install --no-install-recommends -y build-essential flex bison maven ccache
sudo apt-get install --no-install-recommends -y build-essential flex bison maven ccache clang-10 clang++-10
sudo apt-get install --no-install-recommends -y csmith libcsmith-dev
make -C src minisat2-download
- name: Prepare ccache
uses: actions/cache@v3
with:
path: .ccache
key: ${{ runner.os }}-20.04-make-${{ github.ref }}-${{ github.sha }}-CSMITH
key: ${{ runner.os }}-20.04-make-clang-${{ github.ref }}-${{ github.sha }}-CSMITH
restore-keys: |
${{ runner.os }}-20.04-make-${{ github.ref }}
${{ runner.os }}-20.04-make
${{ runner.os }}-20.04-make-clang-${{ github.ref }}
${{ runner.os }}-20.04-make-clang
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
Expand All @@ -36,7 +37,7 @@ jobs:
run: ccache -z --max-size=500M
- name: Build with make
run: |
make -C src CXX='ccache /usr/bin/g++' cbmc.dir goto-cc.dir goto-instrument.dir -j2
make -C src CXX='ccache /usr/bin/clang++' cbmc.dir goto-cc.dir goto-instrument.dir -j2
- name: Print ccache stats
run: ccache -s
- name: Run 10 randomly-generated CSmith tests
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/doxygen-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
branches: [ develop ]

jobs:
# This job takes approximately 2 minutes
check-doxygen:
runs-on: ubuntu-20.04
steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: Publish CBMC documentation
on: [push, pull_request]

jobs:
# This job takes approximately 3 minutes
publish:
runs-on: ubuntu-latest
steps:
Expand Down
Loading