Cleanup GitHub actions #7480
Cleanup GitHub actions #7480
Conversation
| @@ -6,6 +6,7 @@ on: | |||
| - '**' | |||
|
|
|||
| jobs: | |||
| # This job takes approximately 18 minutes | |||
There was a problem hiding this comment.
I understand that these are informational only, but how are we going to track any changes to these numbers?
Or is the plan to be more laid back and only update them if we casually observe any change?
There was a problem hiding this comment.
For now I was thinking keep this informal, but maybe we should go a little further and do actual checks? Don't know, I'm open to suggestions.
| @@ -41,7 +41,7 @@ jobs: | |||
| - name: Build CBMC tools | |||
| run: | | |||
| make -C src minisat2-download | |||
| make -C src CXX='ccache /usr/bin/g++' cbmc.dir goto-cc.dir goto-diff.dir -j2 | |||
There was a problem hiding this comment.
Why did the compiler change here?
There was a problem hiding this comment.
This is to make sure we can actually use the compiler cache (and don't trash it by putting a different configuration in there).
When looking to optimise CI workflows it is useful to have an idea about the current state of affairs.
1. We must use the same build configuration when sharing a particular cache. 2. Don't create additional cache entries when we can safely use one of the existing ones.
Remove stray space.
Use single-instruction commands where possible, making the code use less vertical space (and making different jobs easier to compare).
This will make sure tests still pass on the merged code base. Also, this will make sure caches are actually available on first run in pull requests: GitHub caches are access restricted and caches created by branches in forks will not be considered. Only cache entries for the base branch are always available.
tautschnig
force-pushed
the
cleanup/caching
branch
from
b2d39b0 to
2964edf
Compare
tautschnig
assigned tautschnig and unassigned NlightNFotis, peterschrammel, esteffin, thomasspriggs and TGWDB
Codecov ReportBase: 78.48% // Head: 78.48% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #7480 +/- ##
========================================
Coverage 78.48% 78.48%
========================================
Files 1663 1663
Lines 191188 191188
========================================
Hits 150054 150054
Misses 41134 41134
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Please see individual commit messages.