CONTRACTS: add __CPROVER_obeys_contract predicate #7355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-delmas-3000
added
dependent - do not merge
aws
remi-delmas-3000
requested review from
tautschnig,
feliperodri,
martin-cs,
chris-ryder,
peterschrammel and
kroening
as code owners
Codecov ReportBase: 78.35% // Head: 78.34% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7355 +/- ##
===========================================
- Coverage 78.35% 78.34% -0.02%
===========================================
Files 1645 1646 +1
Lines 190182 190121 -61
===========================================
- Hits 149015 148945 -70
- Misses 41167 41176 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
remi-delmas-3000
force-pushed
the
obeys-contract-predicate
branch
from
ca29e29 to
d67141b
Compare
|
I'll review once #7348 is merged and a possible bug that @remi-delmas-3000 and I just discussed out-of-band has been addressed. |
remi-delmas-3000
force-pushed
the
obeys-contract-predicate
branch
from
d67141b to
c821f5e
Compare
remi-delmas-3000
force-pushed
the
obeys-contract-predicate
branch
from
c821f5e to
c0fd991
Compare
tautschnig
reviewed
Nov 22, 2022
src/goto-instrument/contracts/dynamic-frames/dfcc_obeys_contract.cpp
Outdated
Show resolved
Hide resolved
remi-delmas-3000
force-pushed
the
obeys-contract-predicate
branch
from
c0fd991 to
45651af
Compare
remi-delmas-3000
force-pushed
the
obeys-contract-predicate
branch
from
45651af to
f5e49c9
Compare
tautschnig
approved these changes
Nov 22, 2022
remi-delmas-3000
force-pushed
the
obeys-contract-predicate
branch
3 times, most recently
from
50a54f4 to
71db674
Compare
This predicate can be used in requires and ensures clauses to express that a function pointer satisfies a given contract. The predicate is implemented in cprover_contracts.c and turns into an assignment in assumption contexts and to an equality check in assertions contexts. The dfcc_instrumentt methods were updated to report any occurrence of the predicate discovered when instrumenting GOTO functions.
remi-delmas-3000
force-pushed
the
obeys-contract-predicate
branch
from
71db674 to
272ebf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #7348 (first commit).
Adds a new predicate
__CPROVER_obeys_contract(function_pointer, contract).Allows to specify that a function pointer satisfies a given contract in requires and ensures
clauses of another contract.