CONTRACTS: Drop (requires|ensures)_contract clauses #7348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-delmas-3000
requested review from
tautschnig,
feliperodri,
kroening,
peterschrammel and
chris-ryder
as code owners
remi-delmas-3000
force-pushed
the
remove-requires-ensures-contract-clauses
branch
from
234717d to
5ec6290
Compare
7 tasks
Codecov ReportBase: 78.34% // Head: 78.33% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7348 +/- ##
===========================================
- Coverage 78.34% 78.33% -0.01%
===========================================
Files 1644 1645 +1
Lines 190313 190080 -233
===========================================
- Hits 149097 148900 -197
+ Misses 41216 41180 -36
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
remi-delmas-3000
added
cleanup
aws
tautschnig
approved these changes
Nov 18, 2022
feliperodri
changed the title
feliperodri
approved these changes
Nov 18, 2022
Removes support for contract clauses - `__CPROVER_requires_contract(fptr, contract)` - `__CPROVER_ensures_contract(fptr, contract)` The clause format was cumbersome to use for pointers embedded in other data structures, they will be replaced by a predicate.
remi-delmas-3000
force-pushed
the
remove-requires-ensures-contract-clauses
branch
from
5ec6290 to
6bc4942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes support for contract clauses
__CPROVER_requires_contract(fptr, contract)__CPROVER_ensures_contract(fptr, contract)The clause format was cumbersome to use for pointers embedded in other data structures, they will be replaced by a predicate.
Impacted:
in ansi-c (utils, linking) :
exprtclasses that represented the clausecontracts:
contracts/dynamic-frames
doc:
removing documentation of the clause
Each commit message has a non-empty body, explaining why the change was made.
Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
My commit message includes data points confirming performance improvements (if claimed).
My PR is restricted to a single feature or bugfix.
White-space or formatting changes outside the feature-related changed lines are in commits of their own.