Skip to content

Move has_byte_operator to util #7329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

tautschnig
Copy link
Collaborator

There is nothing solvers-specific to this function. Cleanup in preparation of moving all byte-operator lowering to util.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig force-pushed the cleanup/move-has_byte_op branch from 21069eb to c288042 Compare November 13, 2022 08:31
There is nothing solvers-specific to this function. Cleanup in
preparation of moving all byte-operator lowering to util.
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 78.28% // Head: 78.28% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fce00aa) compared to base (9fd95ed).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7329   +/-   ##
========================================
  Coverage    78.28%   78.28%           
========================================
  Files         1642     1642           
  Lines       189992   190013   +21     
========================================
+ Hits        148734   148758   +24     
+ Misses       41258    41255    -3     
Impacted Files Coverage Δ
src/solvers/flattening/boolbv_equality.cpp 63.63% <ø> (ø)
src/solvers/lowering/byte_operators.cpp 92.71% <ø> (-0.06%) ⬇️
src/util/byte_operators.h 92.72% <ø> (ø)
src/goto-programs/goto_convert.cpp 88.09% <100.00%> (ø)
src/goto-programs/goto_program.h 90.41% <100.00%> (+0.07%) ⬆️
src/util/byte_operators.cpp 93.10% <100.00%> (+3.10%) ⬆️
src/goto-instrument/goto_program2code.cpp 68.81% <0.00%> (-0.03%) ⬇️
src/goto-symex/symex_goto.cpp 97.38% <0.00%> (-0.01%) ⬇️
src/goto-instrument/contracts/contracts.cpp 95.09% <0.00%> (+0.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit b88c233 into diffblue:develop Nov 13, 2022
@tautschnig tautschnig deleted the cleanup/move-has_byte_op branch November 13, 2022 12:57
tautschnig added a commit that referenced this pull request Nov 13, 2022
Move byte-operator lowering to util [depends-on: #7329]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants