Skip to content

Move byte-operator lowering to util [depends-on: #7329] #7330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2022

Conversation

tautschnig
Copy link
Collaborator

Please review commit-by-commit.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Nov 13, 2022
@tautschnig tautschnig force-pushed the feature/move-byte-op-lowering branch 2 times, most recently from a5deff3 to 90df6d4 Compare November 13, 2022 08:39
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 78.28% // Head: 78.28% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (c708326) compared to base (d7dd40a).
Patch coverage: 91.58% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7330      +/-   ##
===========================================
- Coverage    78.28%   78.28%   -0.01%     
===========================================
  Files         1642     1642              
  Lines       189995   190014      +19     
===========================================
+ Hits        148737   148750      +13     
- Misses       41258    41264       +6     
Impacted Files Coverage Δ
src/solvers/flattening/boolbv_byte_extract.cpp 69.73% <ø> (ø)
src/solvers/flattening/boolbv_byte_update.cpp 100.00% <ø> (ø)
src/solvers/flattening/boolbv_equality.cpp 63.63% <ø> (ø)
src/solvers/flattening/boolbv_index.cpp 72.91% <ø> (ø)
src/solvers/smt2/smt2_conv.cpp 66.38% <ø> (ø)
...ncremental/smt2_incremental_decision_procedure.cpp 96.81% <ø> (ø)
src/util/byte_operators.h 92.72% <ø> (ø)
src/cprover/propagate.cpp 65.85% <16.66%> (-8.44%) ⬇️
src/util/lower_byte_operators.cpp 92.70% <95.50%> (ø)
src/util/byte_operators.cpp 93.10% <100.00%> (+3.10%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

There is nothing solvers-specific taking place in this code. Moving this
to util enable future use by expression simplification.
Format according to current indentation and whitespace rules.
@peterschrammel peterschrammel removed their assignment Nov 13, 2022
@tautschnig tautschnig assigned tautschnig and unassigned kroening Nov 13, 2022
@tautschnig tautschnig merged commit ef4e270 into diffblue:develop Nov 13, 2022
@tautschnig tautschnig deleted the feature/move-byte-op-lowering branch November 13, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants