Skip to content

Move CI runners away from macOS-10.15 because of sunsetting by Github. #7028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Move CI runners away from macOS-10.15 because of sunsetting by Github. #7028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37b214c
Move CI runners away from `macOS-10.15` because of sunsetting by Github.
NlightNFotis Jul 22, 2022
156e28e
Delete extraneous `check-macos-11-cmake-clang` job.
NlightNFotis Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 2 additions & 44 deletions .github/workflows/pull-request-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,8 +382,8 @@ jobs:
- name: Run tests
run: cd build; ctest . -V -L THOROUGH -j2

check-macos-10_15-make-clang:
runs-on: macos-10.15
check-macos-11-make-clang:
runs-on: macos-11
Comment on lines +385 to +386
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we then perhaps get rid of check-macos-11-cmake-clang and be content that we have a make-based test for macOS 11 and a CMake-based test for macOS 12?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I diffed the two jobs, and they are essentially the same:

fotiskoutoulakis@192 ~ % diff /tmp/12.yml /tmp/11.yml 
1,2c1,2
< check-macos-12-cmake-clang:
<     runs-on: macos-12
---
> check-macos-11-cmake-clang:
>     runs-on: macos-11

So, the only difference I would reckon is the system toolchain (and other environment parameters), which if they are appropriately exercised by the cmake build, then I don't see any reason to keep it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I went ahead and did just that.

steps:
- uses: actions/checkout@v2
with:
Expand Down Expand Up @@ -432,48 +432,6 @@ jobs:
- name: Run JBMC regression tests
run: make -C jbmc/regression test-parallel JOBS=3

check-macos-11-cmake-clang:
runs-on: macos-11
steps:
- uses: actions/checkout@v2
with:
submodules: recursive
- name: Fetch dependencies
run: brew install cmake ninja maven flex bison ccache z3
- name: Confirm z3 solver is available and log the version installed
run: z3 --version
- name: Download cvc5 binary and make sure it can be deployed
run: |
curl -L https://github.com/cvc5/cvc5/releases/download/cvc5-${{env.cvc5-version}}/cvc5-macOS --output cvc5
chmod u+x cvc5
mv cvc5 /usr/local/bin
cvc5 --version
- name: Prepare ccache
uses: actions/cache@v2
with:
path: .ccache
key: ${{ runner.os }}-Release-${{ github.ref }}-${{ github.sha }}-PR
restore-keys: |
${{ runner.os }}-Release-${{ github.ref }}
${{ runner.os }}-Release
- name: ccache environment
run: |
echo "CCACHE_BASEDIR=$PWD" >> $GITHUB_ENV
echo "CCACHE_DIR=$PWD/.ccache" >> $GITHUB_ENV
- name: Zero ccache stats and limit in size
run: ccache -z --max-size=500M
- name: Configure using CMake
run: |
mkdir build
cd build
cmake .. -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -Dsat_impl=glucose
- name: Build with Ninja
run: cd build; ninja -j3
- name: Print ccache stats
run: ccache -s
- name: Run CTest
run: cd build; ctest -V -L CORE . -j3

check-macos-12-cmake-clang:
runs-on: macos-12
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ jobs:


homebrew-pr:
runs-on: macos-10.15
runs-on: macos-11
steps:
- name: Get release tag name
# The GITHUB_REF we get has refs/tags/ in front of the tag name so we
Expand Down