Skip to content

Move CI runners away from macOS-10.15 because of sunsetting by Github. #7028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

NlightNFotis
Copy link
Contributor

There's a scheduled removal of the image by 30 Aug 2022, with intermittent
failing of those runners to raise awareness to that effect. We need to
move our CI runners to at least macOS-11 to preempt any failures.

Fixes #7027.

There's a scheduled removal of the image by 30 Aug 2022, with intermittent
failing of those runners to raise awareness to that effect. We need to
move our CI runners to at least `macOS-11` to preempt any failures.

Fixes diffblue#7027.
@NlightNFotis NlightNFotis requested a review from a team as a code owner July 22, 2022 16:09
@NlightNFotis NlightNFotis self-assigned this Jul 22, 2022
Comment on lines +385 to +386
check-macos-11-make-clang:
runs-on: macos-11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we then perhaps get rid of check-macos-11-cmake-clang and be content that we have a make-based test for macOS 11 and a CMake-based test for macOS 12?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I diffed the two jobs, and they are essentially the same:

fotiskoutoulakis@192 ~ % diff /tmp/12.yml /tmp/11.yml 
1,2c1,2
< check-macos-12-cmake-clang:
<     runs-on: macos-12
---
> check-macos-11-cmake-clang:
>     runs-on: macos-11

So, the only difference I would reckon is the system toolchain (and other environment parameters), which if they are appropriately exercised by the cmake build, then I don't see any reason to keep it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I went ahead and did just that.

At this point, we have a `cmake` build on both macOS 11 and 12.

It makes more sense to drop one of them (`11`), given that the
environment and toolchain are exercised by the `make` job on the
same platform.

That allows us to simplify our CI pipeline.
@NlightNFotis NlightNFotis force-pushed the move_ci_runners_macos_11 branch from 06c9589 to 156e28e Compare July 22, 2022 16:40
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #7028 (156e28e) into develop (e90aeb3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #7028   +/-   ##
========================================
  Coverage    77.88%   77.88%           
========================================
  Files         1569     1569           
  Lines       180892   180892           
========================================
  Hits        140880   140880           
  Misses       40012    40012           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64034e0...156e28e. Read the comment docs.

@NlightNFotis NlightNFotis merged commit 6766bc4 into diffblue:develop Jul 26, 2022
@NlightNFotis NlightNFotis deleted the move_ci_runners_macos_11 branch July 26, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Actions sunsets images based on macOS-10.15
3 participants