Skip to content

C library: getrandom requires glibc >= 2.25 #6889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2022

Conversation

tautschnig
Copy link
Collaborator

As noticed in Homebrew/homebrew-core#102337,
which attempts to build on Ubuntu 16.04, sys/random.h isn't available
with glibc versions prior to 2.25. Therefore, replace the linux
inclusion check by one that tests for a particular glibc version.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

As noticed in Homebrew/homebrew-core#102337,
which attempts to build on Ubuntu 16.04, sys/random.h isn't available
with glibc versions prior to 2.25. Therefore, replace the __linux__
inclusion check by one that tests for a particular glibc version.
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #6889 (df444b7) into develop (9af369f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #6889   +/-   ##
========================================
  Coverage    77.80%   77.80%           
========================================
  Files         1567     1567           
  Lines       179920   179920           
========================================
  Hits        139992   139992           
  Misses       39928    39928           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3376528...df444b7. Read the comment docs.

@tautschnig tautschnig merged commit e35da92 into diffblue:develop May 27, 2022
@tautschnig tautschnig deleted the bugfixes/cond-getrandom branch May 27, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants