goto_rw/range_spect: gracefully handle arbitrarily large ranges #6768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
changed the title
tautschnig
changed the title
tautschnig
force-pushed
the
bugfixes/goto_rw-large-object
branch
from
6cdf2bd to
3835a7b
Compare
tautschnig
requested review from
martin-cs,
peterschrammel and
chris-ryder
as code owners
tautschnig
assigned peterschrammel, martin-cs and chris-ryder and unassigned tautschnig
Codecov Report
@@ Coverage Diff @@
## develop #6768 +/- ##
========================================
Coverage 77.78% 77.79%
========================================
Files 1567 1567
Lines 179701 179709 +8
========================================
+ Hits 139789 139799 +10
+ Misses 39912 39910 -2
Continue to review full report at Codecov.
|
peterschrammel
approved these changes
May 17, 2022
| @@ -78,10 +78,17 @@ class range_spect | |||
|
|
|||
| static range_spect to_range_spect(const mp_integer &size) | |||
| { | |||
| PRECONDITION(size.is_long()); | |||
| if(!size.is_long()) | |||
There was a problem hiding this comment.
❓ When wouldn't it be a long? A comment would help.
There was a problem hiding this comment.
Comment added, including an example. (A signed long, for example, isn't sufficient to capture a maximum size_t value.)
When the value of an mp_integer doesn't fit into a range_spect::value_type we can safely fall back to using "unknown" instead, which is a safe over-approximation.
tautschnig
force-pushed
the
bugfixes/goto_rw-large-object
branch
from
3835a7b to
f2f218e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the value of an mp_integer doesn't fit into a range_spect::value_type we can safely fall back to using "unknown" instead, which is a safe over-approximation.