-
Notifications
You must be signed in to change notification settings - Fork 273
goto_rw/range_spect: wrap in a class instead of using just a typedef [blocks: #6749, #6768] #6753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR requires #6723 to build. |
663f528
to
d22bc8d
Compare
d22bc8d
to
28a47b5
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6753 +/- ##
===========================================
+ Coverage 77.04% 77.78% +0.73%
===========================================
Files 1594 1567 -27
Lines 185287 179696 -5591
===========================================
- Hits 142763 139782 -2981
+ Misses 42524 39914 -2610
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This helps avoiding magic "-1" constants in this code (which now is range_spect::unknown()).
28a47b5
to
a786ee0
Compare
This helps avoiding magic "-1" constants in this code (which now is
range_spect::unknown()).