Skip to content

goto_rw/range_spect: wrap in a class instead of using just a typedef [blocks: #6749, #6768] #6753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022

Conversation

tautschnig
Copy link
Collaborator

This helps avoiding magic "-1" constants in this code (which now is
range_spect::unknown()).

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig
Copy link
Collaborator Author

This PR requires #6723 to build.

@tautschnig tautschnig self-assigned this Mar 24, 2022
@tautschnig tautschnig force-pushed the cleanup/no-minus-one branch from 663f528 to d22bc8d Compare March 24, 2022 20:16
@tautschnig tautschnig removed their assignment Mar 24, 2022
@tautschnig tautschnig force-pushed the cleanup/no-minus-one branch from d22bc8d to 28a47b5 Compare March 24, 2022 20:55
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #6753 (a786ee0) into develop (3df1868) will increase coverage by 0.73%.
The diff coverage is 88.94%.

@@             Coverage Diff             @@
##           develop    #6753      +/-   ##
===========================================
+ Coverage    77.04%   77.78%   +0.73%     
===========================================
  Files         1594     1567      -27     
  Lines       185287   179696    -5591     
===========================================
- Hits        142763   139782    -2981     
+ Misses       42524    39914    -2610     
Impacted Files Coverage Δ
jbmc/src/jbmc/jbmc_parse_options.cpp 76.51% <ø> (+0.53%) ⬆️
src/cbmc/cbmc_parse_options.cpp 79.90% <ø> (+0.87%) ⬆️
.../goto-instrument/accelerate/acceleration_utils.cpp 2.22% <ø> (ø)
src/goto-instrument/cover_basic_blocks.h 100.00% <ø> (ø)
src/goto-instrument/source_lines.h 100.00% <ø> (ø)
src/goto-instrument/unwind.h 100.00% <ø> (ø)
src/goto-programs/allocate_objects.h 100.00% <ø> (ø)
src/goto-programs/builtin_functions.cpp 58.35% <0.00%> (ø)
src/goto-programs/goto_check.cpp 100.00% <ø> (+18.60%) ⬆️
src/goto-symex/symex_main.cpp 86.97% <ø> (-0.04%) ⬇️
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4d26e0...a786ee0. Read the comment docs.

@tautschnig tautschnig changed the title goto_rw/range_spect: wrap in a class instead of using just a typedef goto_rw/range_spect: wrap in a class instead of using just a typedef [blocks: #6768] Mar 25, 2022
@tautschnig tautschnig changed the title goto_rw/range_spect: wrap in a class instead of using just a typedef [blocks: #6768] goto_rw/range_spect: wrap in a class instead of using just a typedef [blocks: #6749, #6768] Mar 25, 2022
Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

This helps avoiding magic "-1" constants in this code (which now is
range_spect::unknown()).
@tautschnig tautschnig force-pushed the cleanup/no-minus-one branch from 28a47b5 to a786ee0 Compare May 10, 2022 18:05
@tautschnig tautschnig merged commit c83dada into diffblue:develop May 10, 2022
@tautschnig tautschnig deleted the cleanup/no-minus-one branch May 10, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants