goto_check_ct: Transforming assertions and assumptions is language-agnostic

[tautschnig]

There is nothing source language specific about the handling of the
options "assertions", "assumptions", "built-in-assertions" (which are
controlled via command-line options "--no-assertions" and
"--no-assumptions").

This cleanup will enable complete removal of goto_check_java.

This is a necessary step for #6686, which in turn will will simplify #6684 and #6658.

• Each commit message has a non-empty body, explaining why the change was made.
• Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Merging #6687 (f9e2dc8) into develop (222d266) will increase coverage by 0.17%.
The diff coverage is 97.27%.

@@             Coverage Diff             @@
##           develop    #6687      +/-   ##
===========================================
+ Coverage    76.82%   76.99%   +0.17%     
===========================================
  Files         1582     1581       -1     
  Lines       182767   182101     -666     
===========================================
- Hits        140403   140205     -198     
+ Misses       42364    41896     -468     

Impacted Files	Coverage Δ
src/analyses/goto_check_c.cpp	90.78% <ø> (-0.03%)	⬇️
src/goto-programs/string_abstraction.h	100.00% <ø> (ø)
unit/util/piped_process.cpp	31.29% <33.33%> (ø)
src/ansi-c/c_typecheck_expr.cpp	76.45% <50.00%> (ø)
src/goto-programs/string_abstraction.cpp	92.46% <90.90%> (ø)
jbmc/src/janalyzer/janalyzer_parse_options.cpp	48.75% <100.00%> (ø)
jbmc/src/jbmc/jbmc_parse_options.cpp	72.46% <100.00%> (ø)
jbmc/src/jdiff/jdiff_parse_options.cpp	67.74% <100.00%> (-0.35%)	⬇️
src/analyses/goto_check.cpp	81.39% <100.00%> (+17.75%)	⬆️
.../goto-instrument/goto_instrument_parse_options.cpp	69.28% <100.00%> (+0.03%)	⬆️
... and 16 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c1637...f9e2dc8. Read the comment docs.

[kroening]

Approving, but advocating moving this to goto-instrument, where it belongs.

[tautschnig]

Approving, but advocating moving this to goto-instrument, where it belongs.

Ack, will do as a follow-up PR.