Skip to content

move goto_check_ct to ansi-c/ #6658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2022
Merged

move goto_check_ct to ansi-c/ #6658

merged 2 commits into from
Mar 8, 2022

Conversation

kroening
Copy link
Member

The checks done in goto_check_ct are specific to C/C++, and thus belong into
the ansi-c/ directory.

This also moves goto_check to goto-programs/, which right now is merely a
wrapper around goto_check_ct.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig
Copy link
Collaborator

An observation while working on the follow-up commit to this: The following flags, in my opinion, should not be handled by goto_check_ct in the first place:

enable_assert_to_assume = _options.get_bool_option("assert-to-assume");
enable_assertions = _options.get_bool_option("assertions");
enable_built_in_assertions =
    _options.get_bool_option("built-in-assertions");
enable_assumptions = _options.get_bool_option("assumptions");

There is nothing C/C++ specific to these.

@tautschnig tautschnig force-pushed the move_goto_check_c branch 4 times, most recently from de9b595 to 358b409 Compare February 28, 2022 11:33
@tautschnig tautschnig self-assigned this Feb 28, 2022
kroening and others added 2 commits February 28, 2022 14:36
The checks done in goto_check_ct are specific to C/C++, and thus belong into
the ansi-c/ directory.

This also moves goto_checkt to goto-programs/, which right now is merely a
wrapper around goto_check_ct.
White-space changes only.
@tautschnig tautschnig removed their assignment Feb 28, 2022
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #6658 (d3301c0) into develop (1154f13) will decrease coverage by 0.13%.
The diff coverage is 85.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6658      +/-   ##
===========================================
- Coverage    76.92%   76.79%   -0.14%     
===========================================
  Files         1583     1589       +6     
  Lines       183314   183483     +169     
===========================================
- Hits        141018   140898     -120     
- Misses       42296    42585     +289     
Impacted Files Coverage Δ
jbmc/src/java_bytecode/lazy_goto_model.h 100.00% <ø> (+7.40%) ⬆️
jbmc/src/jdiff/jdiff_parse_options.h 100.00% <ø> (ø)
src/analyses/invariant_set.cpp 0.00% <0.00%> (ø)
src/cpp/cpp_typecheck_conversions.cpp 85.14% <0.00%> (+0.10%) ⬆️
src/goto-diff/goto_diff_parse_options.h 100.00% <ø> (ø)
src/goto-instrument/dump_c.cpp 80.49% <0.00%> (+0.28%) ⬆️
src/goto-instrument/dump_c_class.h 100.00% <ø> (ø)
...rc/goto-instrument/goto_instrument_parse_options.h 100.00% <ø> (ø)
src/goto-instrument/goto_program2code.cpp 68.84% <0.00%> (+0.06%) ⬆️
src/goto-programs/string_abstraction.cpp 92.45% <ø> (-0.01%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412d040...d3301c0. Read the comment docs.

@kroening kroening merged commit 3a31976 into develop Mar 8, 2022
@kroening kroening deleted the move_goto_check_c branch March 8, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants