Skip to content

goto_rw: byte extracts may have a negative offset #6668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tautschnig
Copy link
Collaborator

A negative offset can be safely ignored as there is nothing to be read
from or to be written to.

Fixes: #2524

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

A negative offset can be safely ignored as there is nothing to be read
from or to be written to.

Fixes: diffblue#2524
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #6668 (5c3acff) into develop (673bd73) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6668   +/-   ##
========================================
  Coverage    76.76%   76.77%           
========================================
  Files         1582     1582           
  Lines       182357   182358    +1     
========================================
+ Hits        139988   140004   +16     
+ Misses       42369    42354   -15     
Impacted Files Coverage Δ
src/analyses/goto_rw.cpp 55.79% <66.66%> (+3.49%) ⬆️
src/cbmc/cbmc_parse_options.cpp 77.77% <0.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd7a56...5c3acff. Read the comment docs.

@tautschnig
Copy link
Collaborator Author

Closing as #2822 already tackles this issue. Pushing an updated fix to the branch behind #2822 instead.

@tautschnig tautschnig closed this Feb 15, 2022
@tautschnig tautschnig deleted the bugfixes/2524-goto_rw-negative-offset branch February 15, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Range sets cannot handle negative offsets in byte extracts
3 participants