need to check lower bound on index in rw_range_sett::get_objects_byte_extract #2822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
chrisr-diffblue,
martin-cs,
peterschrammel,
smowton and
thk123
as code owners
Closed
|
This seems related to #2524. |
|
Ok, let's see whether that can do a KNOWNBUG -> CORE. |
kroening
force-pushed
the
rw_range_lower_bound_fix
branch
from
3c4ba04 to
8bc1b47
Compare
tautschnig
requested changes
Aug 23, 2018
|
Hi @kroening, is it possible that you address the issues that Michael raised? If not, shall we have this closed please? |
3 tasks
A negative offset may result in a read/write access to a parent object. Fixes: #2524 Co-authored-by: Michael Tautschnig <[email protected]>
tautschnig
force-pushed
the
rw_range_lower_bound_fix
branch
from
8bc1b47 to
afac4a0
Compare
tautschnig
approved these changes
Feb 15, 2022
Codecov Report
@@ Coverage Diff @@
## develop #2822 +/- ##
===========================================
+ Coverage 76.76% 76.82% +0.06%
===========================================
Files 1582 1582
Lines 182360 182769 +409
===========================================
+ Hits 139992 140416 +424
+ Misses 42368 42353 -15
Continue to review full report at Codecov.
|
chris-ryder
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses part of issue #2653