Cleanup goto check java #6503
Merged
Cleanup goto check java #6503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Dec 4, 2021
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
The Java front-end does not offer a bit count operator, and thus, this check is redundant.
Shifts in Java have defined semantics for any combination of values; thus, this check is redundant.
kroening
force-pushed
the
cleanup_goto_check_java
branch
3 times, most recently
from
7a1c49f to
637704f
Compare
The Java front-end processes Java Byte code, which uses control flow to guard the evaluation of expressions.
kroening
force-pushed
the
cleanup_goto_check_java
branch
from
637704f to
fc7da69
Compare
kroening
requested review from
chrisr-diffblue,
martin-cs and
peterschrammel
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #6503 +/- ##
========================================
Coverage 76.08% 76.09%
========================================
Files 1548 1548
Lines 166399 166328 -71
========================================
- Hits 126603 126563 -40
+ Misses 39796 39765 -31
Continue to review full report at Codecov.
|
peterschrammel
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.