-
Notifications
You must be signed in to change notification settings - Fork 273
Basic version of goto-diff tool #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
remove_unused_functions(goto_functions, ui_message_handler); | ||
|
||
//ENHANCE: this should be done somewhere else | ||
if(config.main == "") //no function cmd line option given |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unclear to me why this needs to be done here?
af954aa
to
341d403
Compare
@peterschrammel it may make sense to merge the first 4 patches of my series into "goto-diff initial" or one of the later ones as appropriate. |
Yes. And it needs rebasing too. I'll clean it up as soon as #62 is merged. |
@peterschrammel Thanks for cleaning up #62 and @kroening thanks for merging! Looking forward to getting this one refined, I'll then see what further patches on top of this one I might already have ready for submission. |
@tautschnig, maybe it makes sense to pull your patches into https://github.com/peterschrammel/cbmc/tree/goto-diff right away as they are likely to be invalidated by my clean-up. |
@peterschrammel Apologies for taking a while to get this done, but I've now pushed all the further and create a new pull request with your fork (but you will have noticed anyway). |
922cbfa
to
82ff1fc
Compare
basic syntactic diffing
requires pull request #62