Skip to content

Basic version of goto-diff tool #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2016

Conversation

peterschrammel
Copy link
Member

basic syntactic diffing

requires pull request #62

@peterschrammel peterschrammel mentioned this pull request Apr 8, 2016
@kroening kroening self-assigned this Apr 18, 2016
remove_unused_functions(goto_functions, ui_message_handler);

//ENHANCE: this should be done somewhere else
if(config.main == "") //no function cmd line option given
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear to me why this needs to be done here?

@peterschrammel peterschrammel force-pushed the goto-diff branch 5 times, most recently from af954aa to 341d403 Compare June 9, 2016 04:51
@tautschnig
Copy link
Collaborator

@peterschrammel it may make sense to merge the first 4 patches of my series into "goto-diff initial" or one of the later ones as appropriate.

@peterschrammel
Copy link
Member Author

Yes. And it needs rebasing too. I'll clean it up as soon as #62 is merged.

@tautschnig
Copy link
Collaborator

@peterschrammel Thanks for cleaning up #62 and @kroening thanks for merging! Looking forward to getting this one refined, I'll then see what further patches on top of this one I might already have ready for submission.

@peterschrammel
Copy link
Member Author

@tautschnig, maybe it makes sense to pull your patches into https://github.com/peterschrammel/cbmc/tree/goto-diff right away as they are likely to be invalidated by my clean-up.

@tautschnig
Copy link
Collaborator

@peterschrammel Apologies for taking a while to get this done, but I've now pushed all the further and create a new pull request with your fork (but you will have noticed anyway).

@kroening kroening merged commit 82ff1fc into diffblue:master Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants