JSON output #62
Closed
JSON output #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschrammel
force-pushed
the
json-output
branch
2 times, most recently
from
1c48ffc to
8344daa
Compare
| break; | ||
|
|
||
| case PLAIN: | ||
| break; | ||
|
|
||
| default:; | ||
| default: | ||
| assert(false); |
There was a problem hiding this comment.
My suggestion is to remove default: statements wherever possible as the compiler will warn you about missing cases.
|
@peterschrammel It seems that pull request also needs rebasing before it can be merged? Thanks! |
peterschrammel
force-pushed
the
json-output
branch
2 times, most recently
from
d3be2cd to
24fd582
Compare
|
I have taken into account all your comments now. |
|
Thanks @peterschrammel for all the updates! github says there are still conflicts that need resolving? (Or maybe these are new conflicts.) |
peterschrammel
force-pushed
the
json-output
branch
from
24fd582 to
0a6b616
Compare
|
removed remove_unused_functions changes and the remaining enum-switch default |
|
Partially merged; note that show_goto_functions.cpp was missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--json-ui option
and JSON output for
further TODOs: