Skip to content

Add /fd and /td SHA256 as now necessary #6349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2021

Conversation

NlightNFotis
Copy link
Contributor

An update to the Windows SDK from build 20236 onwards requires
that the /fd and /td options be specified. This commits sets them
both to SHA256 (recommended) in the Windows release build.

Microsoft documentation on this:
https://docs.microsoft.com/en-us/dotnet/framework/tools/signtool-exe

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

An update to the Windows SDK from build 20236 onwards requires
that the /fd and /td options be specified. This commits sets them
both to SHA256 (recommended) in the Windows release build.

Microsoft documentation on this:
https://docs.microsoft.com/en-us/dotnet/framework/tools/signtool-exe
@NlightNFotis NlightNFotis requested a review from a team as a code owner September 17, 2021 16:36
@NlightNFotis NlightNFotis self-assigned this Sep 17, 2021
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #6349 (aca7eba) into develop (e4ee1ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6349   +/-   ##
========================================
  Coverage    75.90%   75.90%           
========================================
  Files         1515     1515           
  Lines       163990   163990           
========================================
  Hits        124469   124469           
  Misses       39521    39521           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd1a8d...aca7eba. Read the comment docs.

@NlightNFotis NlightNFotis merged commit 9d3c8ec into diffblue:develop Sep 19, 2021
@NlightNFotis NlightNFotis deleted the windows_codesigning_fix branch September 19, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants