Merge pull request #6349 from NlightNFotis/windows_codesigning_fix

NlightNFotis · web-flow · commit 9d3c8ec97903 · 2021-09-19T22:22:23.000+01:00
Add /fd and /td SHA256 as now necessary
diff --git a/.github/workflows/release-packages.yaml b/.github/workflows/release-packages.yaml
@@ -207,7 +207,7 @@ jobs:
           $servers = @('http://ts.ssl.com', 'http://timestamp.digicert.com', 'http://timestamp.sectigo.com')
           foreach($ts_server in $servers)
           {
-            & signtool.exe sign /f $env:pfxcert /p "${{ secrets.CODESIGNCERTPASSWORD }}" /tr $ts_server ${{ steps.create_packages.outputs.msi_installer }}
+            & signtool.exe sign /f $env:pfxcert /p "${{ secrets.CODESIGNCERTPASSWORD }}" /tr $ts_server ${{ steps.create_packages.outputs.msi_installer } /td SHA256 /fd SHA256}
             if ($LastExitCode -eq "0")
             {
               # Stop if code-signing the binary using this server was successful.

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ jobs:`
`207`	`207`	`$servers = @('http://ts.ssl.com', 'http://timestamp.digicert.com', 'http://timestamp.sectigo.com')`
`208`	`208`	`foreach($ts_server in $servers)`
`209`	`209`	`{`
`210`		`- & signtool.exe sign /f $env:pfxcert /p "${{ secrets.CODESIGNCERTPASSWORD }}" /tr $ts_server ${{ steps.create_packages.outputs.msi_installer }}`
	`210`	`+ & signtool.exe sign /f $env:pfxcert /p "${{ secrets.CODESIGNCERTPASSWORD }}" /tr $ts_server ${{ steps.create_packages.outputs.msi_installer } /td SHA256 /fd SHA256}`
`211`	`211`	`if ($LastExitCode -eq "0")`
`212`	`212`	`{`
`213`	`213`	`# Stop if code-signing the binary using this server was successful.`