Skip to content

[CI] Remove fixed windows SDK version lookup. #5971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2021
Merged

[CI] Remove fixed windows SDK version lookup. #5971

merged 1 commit into from
Mar 24, 2021

Conversation

NlightNFotis
Copy link
Contributor

Before this, we were looking for the codesign tool under a specific
folder, signifying a specific version of the Windows SDK. But Github
Action Runner Software is being updated every now and then, causing
this dependency to be wobbly.

This should make the tool lookup more robust for future SDK version
updates as well.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@NlightNFotis
Remove fixed windows SDK version lookup.
2459a7a 
Before this, we were looking for the codesign tool under a specific
folder, signifying a specific version of the Windows SDK. But Github
Action Runner Software is being updated every now and then, causing
this dependency to be wobbly.

This should make the tool lookup more robust for future SDK version
updates as well.
@NlightNFotis NlightNFotis requested a review from a team March 24, 2021 10:15
@NlightNFotis NlightNFotis self-assigned this Mar 24, 2021
hannes-steffenhagen-diffblue
hannes-steffenhagen-diffblue approved these changes Mar 24, 2021
View reviewed changes
.github/workflows/release-packages.yaml
@@ -153,7 +153,7 @@ jobs:
uses: microsoft/[email protected]
- name: Setup code sign environment
run: |
echo "$(Split-Path -Path $(Get-ChildItem -Path ${env:ProgramFiles(x86)} -Recurse -Filter 'signtool.exe' | Where-Object FullName -like '*10.0.19041.0\x64\signtool.exe').FullName)" >> $env:GITHUB_PATH
echo "$(Split-Path -Path $(Get-ChildItem -Path ${env:ProgramFiles(x86)} -Recurse -Filter 'signtool.exe' | Where-Object FullName -like '*10.0.*\x64\signtool.exe').FullName)" >> $env:GITHUB_PATH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear there already was an action or something along the lines that did more or less this, but I suppose this is more robust than the previous version. Might cause slight problems if there are multiple SDK versions, but then again I don't think it really matters which version of sign tool you use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple SDK versions pre-installed (https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md), but I also figured it shouldn't matter which SDK (minor) version the code sign tool we use is attached to.

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #5971 (2459a7a) into develop (85dd63b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5971   +/-   ##
========================================
  Coverage    75.01%   75.01%           
========================================
  Files         1431     1431           
  Lines       155609   155609           
========================================
  Hits        116732   116732           
  Misses       38877    38877

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca65cf9...2459a7a. Read the comment docs.

@NlightNFotis NlightNFotis merged commit f899754 into diffblue:develop Mar 24, 2021
@NlightNFotis NlightNFotis deleted the codesign_fix branch March 24, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue approved these changes

@thomasspriggs thomasspriggs thomasspriggs approved these changes

@TGWDB TGWDB TGWDB approved these changes

Assignees

@NlightNFotis NlightNFotis

Labels
bugfix CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NlightNFotis @hannes-steffenhagen-diffblue @thomasspriggs @TGWDB