Skip to content

Commit 2459a7a

Browse files
committed
Remove fixed windows SDK version lookup.
Before this, we were looking for the codesign tool under a specific folder, signifying a specific version of the Windows SDK. But Github Action Runner Software is being updated every now and then, causing this dependency to be wobbly. This should make the tool lookup more robust for future SDK version updates as well.
1 parent ca65cf9 commit 2459a7a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/release-packages.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ jobs:
153153
uses: microsoft/[email protected]
154154
- name: Setup code sign environment
155155
run: |
156-
echo "$(Split-Path -Path $(Get-ChildItem -Path ${env:ProgramFiles(x86)} -Recurse -Filter 'signtool.exe' | Where-Object FullName -like '*10.0.19041.0\x64\signtool.exe').FullName)" >> $env:GITHUB_PATH
156+
echo "$(Split-Path -Path $(Get-ChildItem -Path ${env:ProgramFiles(x86)} -Recurse -Filter 'signtool.exe' | Where-Object FullName -like '*10.0.*\x64\signtool.exe').FullName)" >> $env:GITHUB_PATH
157157
echo "pfxcert=$([string](Get-Location)+'\CodeSignCertificate.pfx')" >> $env:GITHUB_ENV
158158
- name: Prepare ccache
159159
uses: actions/cache@v2

0 commit comments

Comments
 (0)