Skip to content

Remove "show" target from regression/*/Makefile #5957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

tautschnig
Copy link
Collaborator

This may have been useful to someone in the past, but a semi-interactive
(starting a new vim in a loop for each directory) approach with several
hundred files is no longer meaningful.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #5957 (3a5ddc7) into develop (867168c) will increase coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5957      +/-   ##
===========================================
+ Coverage    74.24%   75.02%   +0.77%     
===========================================
  Files         1431     1431              
  Lines       155290   155295       +5     
===========================================
+ Hits        115290   116504    +1214     
+ Misses       40000    38791    -1209     
Impacted Files Coverage Δ
src/util/simplify_expr_int.cpp 83.92% <0.00%> (+0.32%) ⬆️
src/goto-programs/goto_program.h 91.17% <0.00%> (+0.32%) ⬆️
src/symtab2gb/symtab2gb_parse_options.cpp 60.65% <0.00%> (+1.33%) ⬆️
src/goto-programs/goto_program.cpp 66.37% <0.00%> (+2.10%) ⬆️
src/pointer-analysis/value_set.cpp 82.63% <0.00%> (+3.26%) ⬆️
.../goto-instrument/goto_instrument_parse_options.cpp 67.90% <0.00%> (+4.67%) ⬆️
src/goto-instrument/wmm/event_graph.cpp 13.58% <0.00%> (+13.58%) ⬆️
src/assembler/remove_asm.cpp 50.71% <0.00%> (+13.87%) ⬆️
src/analyses/static_analysis.cpp 47.52% <0.00%> (+14.35%) ⬆️
src/util/graph.h 97.28% <0.00%> (+14.57%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c923c3d...3a5ddc7. Read the comment docs.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this and have not heard of a user for a long time (something makes me think I saw @peterschrammel using it in ... 2015?) but maybe we should give this one a little so that, in the unlikely event of anyone having strong feelings about it, they have time to object.

@tautschnig tautschnig self-assigned this Mar 19, 2021
This may have been useful to someone in the past, but a semi-interactive
(starting a new vim in a loop for each directory) approach with several
hundred files is no longer meaningful.
@tautschnig tautschnig merged commit efc313d into diffblue:develop Mar 22, 2021
@tautschnig tautschnig deleted the no-show branch March 22, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants