-
Notifications
You must be signed in to change notification settings - Fork 274
Enable goto-analyzer-simplify regression tests #5933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable goto-analyzer-simplify regression tests #5933
Conversation
af6da00
to
b639fc9
Compare
ce8e220
to
cfd1653
Compare
Updated scripts and test specifications to work in current environments.
cfd1653
to
de9b6e2
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5933 +/- ##
========================================
Coverage 73.95% 73.95%
========================================
Files 1431 1431
Lines 155291 155291
========================================
+ Hits 114842 114853 +11
+ Misses 40449 40438 -11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and preserve the original configuration. I have also checked the tests and I think the results are correct.
|
||
show: | ||
@for dir in *; do \ | ||
if [ -d "$$dir" ]; then \ | ||
vim -o "$$dir/*.c" "$$dir/*.out"; \ | ||
vim -o "$$dir/*.java" "$$dir/*.out"; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??? Why change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, my bad, I copied regression/goto-analyzer/Makefile
. I suppose both should be changed, or perhaps we should just get rid of this show
target. Will create a PR for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally done in #5957.
Updated scripts and test specifications to work in current environments.