Skip to content

Enable goto-analyzer-simplify regression tests #5933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

tautschnig
Copy link
Collaborator

Updated scripts and test specifications to work in current environments.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig force-pushed the regression-tests-simplify branch from af6da00 to b639fc9 Compare March 15, 2021 22:25
@tautschnig tautschnig self-assigned this Mar 16, 2021
@tautschnig tautschnig force-pushed the regression-tests-simplify branch 2 times, most recently from ce8e220 to cfd1653 Compare March 17, 2021 19:11
Updated scripts and test specifications to work in current environments.
@tautschnig tautschnig force-pushed the regression-tests-simplify branch from cfd1653 to de9b6e2 Compare March 17, 2021 20:00
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #5933 (de9b6e2) into develop (0b7431f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5933   +/-   ##
========================================
  Coverage    73.95%   73.95%           
========================================
  Files         1431     1431           
  Lines       155291   155291           
========================================
+ Hits        114842   114853   +11     
+ Misses       40449    40438   -11     
Impacted Files Coverage Δ
...-sensitivity/value_set_pointer_abstract_object.cpp 81.17% <0.00%> (+2.35%) ⬆️
src/analyses/ai_domain.cpp 60.00% <0.00%> (+30.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac11ec8...de9b6e2. Read the comment docs.

@tautschnig tautschnig removed their assignment Mar 17, 2021
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and preserve the original configuration. I have also checked the tests and I think the results are correct.


show:
@for dir in *; do \
if [ -d "$$dir" ]; then \
vim -o "$$dir/*.c" "$$dir/*.out"; \
vim -o "$$dir/*.java" "$$dir/*.out"; \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??? Why change this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my bad, I copied regression/goto-analyzer/Makefile. I suppose both should be changed, or perhaps we should just get rid of this show target. Will create a PR for this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally done in #5957.

@martin-cs martin-cs merged commit 5d83cc4 into diffblue:develop Mar 17, 2021
@tautschnig tautschnig deleted the regression-tests-simplify branch March 17, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants