Do not use invalid_source_file_exceptiont without source location

[tautschnig]

In preparation of tying invalid_source_file_exceptiont to an actual
source location, introduce an exception that is thrown when some invalid
input is encountered, but a precise source location is not known at the
time of throwing the exception.

• Each commit message has a non-empty body, explaining why the change was made.
• Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Merging #5835 (d63c7f0) into develop (afc53d8) will increase coverage by 0.00%.
The diff coverage is 53.65%.

@@           Coverage Diff            @@
##           develop    #5835   +/-   ##
========================================
  Coverage    76.73%   76.73%           
========================================
  Files         1579     1579           
  Lines       181999   181995    -4     
========================================
- Hits        139652   139650    -2     
+ Misses       42347    42345    -2     

Impacted Files	Coverage Δ
jbmc/src/java_bytecode/lazy_goto_model.cpp	82.17% <0.00%> (ø)
src/crangler/ctokenit.cpp	0.00% <0.00%> (ø)
src/crangler/mini_c_parser.cpp	72.67% <0.00%> (ø)
src/goto-programs/slice_global_inits.h	0.00% <0.00%> (ø)
src/goto-programs/string_instrumentation.h	0.00% <0.00%> (ø)
src/memory-analyzer/analyze_symbol.cpp	72.98% <0.00%> (ø)
src/symtab2gb/symtab2gb_parse_options.cpp	63.38% <0.00%> (ø)
unit/testing-utils/get_goto_model_from_c.cpp	89.47% <0.00%> (+2.29%)	⬆️
jbmc/src/java_bytecode/java_bytecode_language.cpp	92.80% <50.00%> (+0.13%)	⬆️
src/util/exception_utils.cpp	91.66% <84.61%> (-2.68%)	⬇️
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c351198...d63c7f0. Read the comment docs.

[martin-cs]

Seems reasonable.

[chrisr-diffblue]

Thanks - thats a nice cleanup improvement. As an aside, I can't help thinking an additional intermediate class in the exception hierarchy - something like a cprover_exception_with_descriptiont to cover what appears to be the very common pattern of "exception is constructed from a std::string argument, and what() just returns that string" might make exception_utils.{h,cpp} somewhat more succinct... one for another day though!

[tautschnig]

Thanks - thats a nice cleanup improvement. As an aside, I can't help thinking an additional intermediate class in the exception hierarchy - something like a cprover_exception_with_descriptiont to cover what appears to be the very common pattern of "exception is constructed from a std::string argument, and what() just returns that string" might make exception_utils.{h,cpp} somewhat more succinct... one for another day though!

Good call! I'm about to add a commit to #5837 to sort this out. I did, however, opt to make cprover_exception_baset that very class: all inheriting classes want that description.

[tautschnig]

Thanks - thats a nice cleanup improvement. As an aside, I can't help thinking an additional intermediate class in the exception hierarchy - something like a cprover_exception_with_descriptiont to cover what appears to be the very common pattern of "exception is constructed from a std::string argument, and what() just returns that string" might make exception_utils.{h,cpp} somewhat more succinct... one for another day though!

Good call! I'm about to add a commit to #5837 to sort this out. I did, however, opt to make cprover_exception_baset that very class: all inheriting classes want that description.

... and now also made this a PR of its own in #6608.

[chrisr-diffblue]

Thanks - thats a nice cleanup improvement. As an aside, I can't help thinking an additional intermediate class in the exception hierarchy - something like a cprover_exception_with_descriptiont to cover what appears to be the very common pattern of "exception is constructed from a std::string argument, and what() just returns that string" might make exception_utils.{h,cpp} somewhat more succinct... one for another day though!

Good call! I'm about to add a commit to #5837 to sort this out. I did, however, opt to make cprover_exception_baset that very class: all inheriting classes want that description.

... and now also made this a PR of its own in #6608.

You're too good to us... :-)