Do not use invalid_source_file_exceptiont without source location

In preparation of tying invalid_source_file_exceptiont to an actual
source location, introduce an exception that is thrown when some invalid
input is encountered, but a precise source location is not known at the
time of throwing the exception.

Author: tautschnig

jbmc/src/java_bytecode/java_bytecode_language.cpp

@@ -318,7 +318,7 @@ void java_bytecode_languaget::initialize_class_loader()
 
 static void throwMainClassLoadingError(const std::string &main_class)
 {
-  throw invalid_source_file_exceptiont(
+  throw system_exceptiont(
     "Error: Could not find or load main class " + main_class);
 }
 
@@ -392,8 +392,7 @@ bool java_bytecode_languaget::parse(
     std::ifstream jar_file(path);
     if(!jar_file.good())
     {
-      throw invalid_source_file_exceptiont(
-        "Error: Unable to access jarfile " + path);
+      throw system_exceptiont("Error: Unable to access jarfile " + path);
     }
 
     // build an object to potentially limit which classes are loaded

jbmc/src/java_bytecode/lazy_goto_model.cpp

@@ -152,14 +152,14 @@ void lazy_goto_modelt::initialize(
 
     if(dynamic_cast<java_bytecode_languaget &>(language).parse())
     {
-      throw invalid_source_file_exceptiont("PARSING ERROR");
+      throw invalid_input_exceptiont("PARSING ERROR");
     }
 
     msg.status() << "Converting" << messaget::eom;
 
     if(language_files.typecheck(symbol_table))
     {
-      throw invalid_source_file_exceptiont("CONVERSION ERROR");
+      throw invalid_input_exceptiont("CONVERSION ERROR");
     }
   }
   else

src/crangler/ctokenit.cpp

@@ -46,7 +46,7 @@ ctokenitt match_bracket(ctokenitt t, char open, char close)
   while(true)
   {
     if(!t)
-      throw invalid_source_file_exceptiont("expected " + std::string(1, close));
+      throw invalid_input_exceptiont("expected " + std::string(1, close));
 
     const auto &token = *(t++);
 

src/crangler/mini_c_parser.cpp

@@ -143,7 +143,7 @@ void mini_c_parsert::parse_brackets(char open, char close, tokenst &dest)
   while(true)
   {
     if(eof())
-      throw invalid_source_file_exceptiont("expected " + std::string(1, close));
+      throw invalid_input_exceptiont("expected " + std::string(1, close));
 
     auto &token = consume_token();
     dest.push_back(token);
@@ -297,7 +297,7 @@ mini_c_parsert::tokenst mini_c_parsert::parse_initializer()
     while(true)
     {
       if(eof())
-        throw invalid_source_file_exceptiont("expected an initializer");
+        throw invalid_input_exceptiont("expected an initializer");
       auto &token = consume_token();
       result.push_back(token);
       if(token == ';')
@@ -317,7 +317,7 @@ mini_c_parsert::tokenst mini_c_parsert::parse_initializer()
     while(true)
     {
       if(eof())
-        throw invalid_source_file_exceptiont("eof in function body");
+        throw invalid_input_exceptiont("eof in function body");
       auto &token = consume_token();
       result.push_back(token);
       if(token == '{')

src/memory-analyzer/analyze_symbol.cpp

@@ -350,7 +350,7 @@ exprt gdb_value_extractort::get_pointer_to_function_value(
   const auto function_symbol = symbol_table.lookup(function_name);
   if(function_symbol == nullptr)
   {
-    throw invalid_source_file_exceptiont{
+    throw invalid_input_exceptiont{
       "input source code does not contain function: " + function_name};
   }
   CHECK_RETURN(function_symbol->type.id() == ID_code);

src/symtab2gb/symtab2gb_parse_options.cpp

@@ -90,8 +90,8 @@ static void run_symtab2gb(
 
     if(failed(linking(linked_symbol_table, symtab, message_handler)))
     {
-      throw invalid_source_file_exceptiont{"failed to link `" +
-                                           symtab_filename + "'"};
+      throw invalid_input_exceptiont{
+        "failed to link `" + symtab_filename + "'"};
     }
   }
 

src/util/exception_utils.cpp

@@ -80,6 +80,16 @@ analysis_exceptiont::analysis_exceptiont(std::string reason)
 {
 }
 
+invalid_input_exceptiont::invalid_input_exceptiont(std::string reason)
+  : m_reason(std::move(reason))
+{
+}
+
+std::string invalid_input_exceptiont::what() const
+{
+  return m_reason;
+}
+
 invalid_source_file_exceptiont::invalid_source_file_exceptiont(
   std::string reason)
   : cprover_exception_baset(std::move(reason))

src/util/exception_utils.h

@@ -156,6 +156,19 @@ class analysis_exceptiont : public cprover_exception_baset
   explicit analysis_exceptiont(std::string reason);
 };
 
+/// Thrown when user-provided input cannot be processed. Use
+/// \ref invalid_source_file_exceptiont when the precise location of erroneous
+/// input is known.
+class invalid_input_exceptiont : public cprover_exception_baset
+{
+public:
+  explicit invalid_input_exceptiont(std::string reason);
+  std::string what() const override;
+
+protected:
+  std::string m_reason;
+};
+
 /// Thrown when we can't handle something in an input source file.
 /// For example, if we get C source code that is not syntactically valid
 /// or that has type errors.

unit/testing-utils/get_goto_model_from_c.cpp

@@ -58,7 +58,7 @@ goto_modelt get_goto_model_from_c(std::istream &in)
     const bool error = language.parse(in, "");
 
     if(error)
-      throw invalid_source_file_exceptiont("parsing failed");
+      throw invalid_input_exceptiont("parsing failed");
   }
 
   language_file.get_modules();
@@ -69,16 +69,15 @@ goto_modelt get_goto_model_from_c(std::istream &in)
     const bool error = language_files.typecheck(goto_model.symbol_table);
 
     if(error)
-      throw invalid_source_file_exceptiont("typechecking failed");
+      throw invalid_input_exceptiont("typechecking failed");
   }
 
   {
     const bool error =
       language_files.generate_support_functions(goto_model.symbol_table);
 
     if(error)
-      throw invalid_source_file_exceptiont(
-        "support function generation failed");
+      throw invalid_input_exceptiont("support function generation failed");
   }
 
   goto_convert(