Skip to content

Use cprover-api Maven dependency in java-models-library #5684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 31, 2020

Conversation

peterschrammel
Copy link
Member

This clearly separates java-models-library from the API exposed by JBMC.
Depends on diffblue/java-models-library#34.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message). - tests in jbmc/regressions/jbmc-concurrency
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #5684 (e4cd6ac) into develop (203bb3c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5684   +/-   ##
========================================
  Coverage    69.50%   69.50%           
========================================
  Files         1243     1243           
  Lines       100680   100690   +10     
========================================
+ Hits         69981    69989    +8     
- Misses       30699    30701    +2     
Flag Coverage Δ
cproversmt2 43.15% <ø> (ø)
regression 66.40% <ø> (+<0.01%) ⬆️
unit 32.25% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/solvers/strings/string_builtin_function.h 74.39% <0.00%> (-2.44%) ⬇️
jbmc/src/java_bytecode/java_utils.cpp 92.72% <0.00%> (ø)
...code/java_bytecode_concurrency_instrumentation.cpp 97.20% <0.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 203bb3c...e4cd6ac. Read the comment docs.

@peterschrammel peterschrammel force-pushed the use-java-cprover-api branch 5 times, most recently from 2c34bc5 to 2419220 Compare December 30, 2020 15:54
@peterschrammel peterschrammel merged commit a0dbf74 into diffblue:develop Dec 31, 2020
@peterschrammel peterschrammel deleted the use-java-cprover-api branch December 31, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants