-
Notifications
You must be signed in to change notification settings - Fork 274
Disable clang format for java #5069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable clang format for java #5069
Conversation
89605f9
to
0d46406
Compare
The clang-format job passed with #5068 cherry-picked (https://travis-ci.org/diffblue/cbmc/jobs/578725706), which confirms that this works. I stopped CI and removed those commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: 0d46406).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/125208912
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
Codecov Report
@@ Coverage Diff @@
## develop #5069 +/- ##
========================================
Coverage 69.54% 69.54%
========================================
Files 1315 1315
Lines 108959 108959
========================================
Hits 75775 75775
Misses 33184 33184 Continue to review full report at Codecov.
|
0d46406
to
74d1d6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 74d1d6f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/125419472
Running clang-format on java was turned on in #4926, to stop clang-format from silently aborting. This PR makes it ignore java, rather than applying any reformatting to it, which is closer to what we were doing before (but without the problem of silently aborting). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I keep forgetting to run clang-format on .java files and don't really like the current result of running it.
👍
This PR should disable clang-format for java. I don't think we are particularly prescriptive about our java style, and it's annoying when PRs fail because of a java formatting issue. I've cherry-picked #5068 which is currently failing for this reason to check that it works. I've marked it "Do not merge" until those two commits have been removed.