-
Notifications
You must be signed in to change notification settings - Fork 274
[TG-9219] Add new option --ignore-manifest-main-class #5068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TG-9219] Add new option --ignore-manifest-main-class #5068
Conversation
cfbfc87
to
f3c9735
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5068 +/- ##
===========================================
+ Coverage 69.61% 69.61% +<.01%
===========================================
Files 1316 1316
Lines 109087 109091 +4
===========================================
+ Hits 75939 75944 +5
+ Misses 33148 33147 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: f3c9735).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/125212217
f3c9735
to
cbe9391
Compare
I generalised the regression test as requested by @segun3d, to use two different packages in the jar file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: cbe9391).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/125261944
cbe9391
to
a49fd3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: a49fd3d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/125275386
@antlechner, the failing regression test should be fixed by rebasing. |
a49fd3d
to
974f6a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 974f6a0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/125499169
974f6a0
to
7fabc9d
Compare
More tests added as requested by @segun3d (one with --main-class, one with --function, one with both, and one without --ignore...). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 7fabc9d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/125790120
If the option is specified, any main class that may be specified in the manifest file of a JAR will be ignored in the class loading stage. This is useful when we want to e.g. load all classes in a JAR file, some of which may not be referenced from the specified main class.
7fabc9d
to
54ee1a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: 54ee1a9).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/125924156
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA review [Passed]
Added regression tests looks well covered. Many thanks 🙂
If the option is specified, any main class that may be specified in the manifest file of a JAR will be ignored in the class loading stage.
This is useful when we want to e.g. load all classes in a JAR file, some of which may not be referenced from the specified main class.