Skip to content

Add test for inherited method on functional interface #5023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thk123
Copy link
Contributor

@thk123 thk123 commented Aug 15, 2019

Apologies for my over eager merging of #5013 Added the test @smowton requested in the original PR

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [na] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [na] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@thk123 thk123 requested a review from smowton August 15, 2019 11:02
@@ -7,10 +7,13 @@ Test.class
^ignoring invokedynamic at java::Test.main:\(\)V address 0 which produces a stub type java::StubInterface
^ignoring invokedynamic at java::Test.main:\(\)V address 6 which produces type java::StubSuperinterface which should have exactly one abstract method but actually has 0.
^ignoring invokedynamic at java::Test.main:\(\)V address 12 which produces type java::InterfaceDeclaringEquals which should have exactly one abstract method but actually has 2.
^ignoring invokedynamic at java::Test.main:\(\)V address 18 which produces type java::InterfaceWithDefaults which should have exactly one abstract method but actually has 2.
^ignoring invokedynamic at java::Test.main:\(\)V address 18 which produces type java::InterfaceWithDefaults
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally breaking this line?

@thk123 thk123 force-pushed the test-for-inherited-functional-method branch from 2574a25 to ffb82b3 Compare August 27, 2019 15:47
@thk123 thk123 requested a review from NathanJPhillips August 27, 2019 15:50
@thk123
Copy link
Contributor Author

thk123 commented Aug 27, 2019

Rebased to fix doxygen problem and address @smowton comment
@NathanJPhillips @smowton could you both review this thanks?

@thk123 thk123 force-pushed the test-for-inherited-functional-method branch from ffb82b3 to 3a4143e Compare August 28, 2019 08:56
@thk123
Copy link
Contributor Author

thk123 commented Aug 28, 2019

clang format issue addressed (I didn't even know we formatted java files...)

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 3a4143e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/124888973

@thk123 thk123 merged commit 6139b6c into diffblue:develop Aug 29, 2019
@thk123 thk123 deleted the test-for-inherited-functional-method branch August 29, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants