Skip to content

Improve error message when functional method is inherited #5013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

thk123
Copy link
Contributor

@thk123 thk123 commented Aug 13, 2019

This error can be erroneously triggered both when there are default methods on the interface (meaning >1 methods) or when the method is actually defined in an inherited interface (meaning 0 methods). Extend the warning message to explain both cases.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • [n.a] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [n/a] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This error can be erroneously triggered both when there are default
methods on the interface (meaning >1 methods) or when the method is
actually defined in an inherited interface (meaning 0 methods). Extend
the warning message to explain both cases.
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, hadn't thought of that

@smowton
Copy link
Contributor

smowton commented Aug 13, 2019

Consider adding a FUTURE test for this?

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 5466c08).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/122986140

@smowton
Copy link
Contributor

smowton commented Aug 15, 2019

True. My shortcomings probably shouldn't serve as excuse though ;)

@thk123
Copy link
Contributor Author

thk123 commented Aug 15, 2019

Not only is there such a test, but there is also a test for exactly this - both in lambda-unhandled-types

@thk123
Copy link
Contributor Author

thk123 commented Aug 15, 2019

@thk123 thk123 merged commit 31c0c5d into diffblue:develop Aug 15, 2019
@thk123 thk123 deleted the improve-interface-warning branch August 15, 2019 10:40
@smowton
Copy link
Contributor

smowton commented Aug 15, 2019

Note that test specifically looks for a stub superinterface, is that the case here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants