Skip to content

Float 0 to string implementation #4700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file not shown.
15 changes: 15 additions & 0 deletions jbmc/regression/jbmc-strings/float-to-string/Test.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
public class Test {

static void checkStringInputValue(float f) {
String s = Float.toString(f);
// the 1/f is needed to distinguish -0 from 0, '==' disregards the
// difference, while the division yields +Infinity or -Infinity.
if (f == 0.0f && 1/f > 0) {
assert(s.equals("0.0"));
} else if (f == -0.0f && 1/f < 0) {
assert(s.equals("-0.0"));
} else if (f == 1.0f ) {
assert(s.equals("1.0"));
}
}
}
8 changes: 8 additions & 0 deletions jbmc/regression/jbmc-strings/float-to-string/test2.desc
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
CORE
Test.class
--function Test.checkStringInputValue --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar`
^EXIT=0$
^SIGNAL=0$
assertion.1.*SUCCESS
assertion.2.*SUCCESS
assertion.3.*SUCCESS
16 changes: 16 additions & 0 deletions jbmc/src/java_bytecode/java_string_library_preprocess.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -950,6 +950,22 @@ code_blockt java_string_library_preprocesst::make_float_to_string_code(
string_literal_to_string_expr("-Infinity", loc, symbol_table, code);
string_expr_list.push_back(minus_infinity);

// Case of 0.0
// Note: for zeros we must use equal_exprt and not ieee_float_equal_exprt,
// the latter disregards the sign
condition_list.push_back(equal_exprt(arg, zero));
const refined_string_exprt zero_string =
string_literal_to_string_expr("0.0", loc, symbol_table, code);
string_expr_list.push_back(zero_string);

// Case of -0.0
ieee_floatt minus_zero_float(float_spec);
minus_zero_float.from_float(-0.0f);
condition_list.push_back(equal_exprt(arg, minus_zero_float.to_expr()));
const refined_string_exprt minus_zero_string =
string_literal_to_string_expr("-0.0", loc, symbol_table, code);
string_expr_list.push_back(minus_zero_string);

// Case of simple notation
ieee_floatt bound_inf_float(float_spec);
ieee_floatt bound_sup_float(float_spec);
Expand Down