Skip to content

Float 0 to string implementation #4700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2019
Merged

Float 0 to string implementation #4700

merged 1 commit into from
May 24, 2019

Conversation

forejtv
Copy link
Contributor

@forejtv forejtv commented May 23, 2019

Before, 0 and -0 would be converted using the scientific-conversion branch, leading to incorrect results (string representation of small nonzero number).

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Before, 0 and -0 would be converted using the scientific-conversion branch, leading to incorrect results (string representation of small nonzero number).
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 0599403).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/112947936

@forejtv forejtv merged commit 8febc81 into diffblue:develop May 24, 2019
@forejtv forejtv deleted the forejtv/float-zero branch May 24, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants