Skip to content

Update java-models-library for diffblue/java-models-library#19 (getMo… #4476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

romainbrenguier
Copy link
Contributor

…nitorCount)

diffblue/java-models-library#19

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig
Copy link
Collaborator

Does this supersede #3464?

@tautschnig
Copy link
Collaborator

Also, would it be possible to include any tests that now work/produce a different result?

@romainbrenguier
Copy link
Contributor Author

@tautschnig

Does this supersede #3464?

I'm waiting for CI to see if it solves the problem of #3464 and it does, then yes it will supersede it.

@romainbrenguier romainbrenguier force-pushed the update-java-models-library/PR19 branch 2 times, most recently from 6109418 to f9caf41 Compare April 1, 2019 09:41
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: f9caf41).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/106541354

This shows that the changes brought with the update are working
correctly.
Unwind 6 should be enough to detect any error and makes jbmc end quicker
than with 30.
The check for VERIFICATION FAILED could match a null pointer check
rather than an assertion.
@romainbrenguier romainbrenguier force-pushed the update-java-models-library/PR19 branch from f9caf41 to 4254f76 Compare April 1, 2019 10:53
@romainbrenguier
Copy link
Contributor Author

Now pointing to master and including more tests, superseeds #3464

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 4254f76).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/106550266

@romainbrenguier romainbrenguier merged commit 4a277c4 into diffblue:develop Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants