Skip to content

Update jbmc/lib/java-models-library for PR16 (getChars) and activate Tests #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

romainbrenguier
Copy link
Contributor

@romainbrenguier romainbrenguier commented Nov 25, 2018

diffblue/java-models-library#16

  • Each commit message has a non-empty body, explaining why the change was made.
  • [na] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [na] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • [na] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@romainbrenguier romainbrenguier force-pushed the update-java-models-library/PR16 branch 2 times, most recently from a408e42 to a2f8fb3 Compare November 25, 2018 21:28
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: a2f8fb3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/92481187

@peterschrammel
Copy link
Member

Tagging Do not merge because the java-models-library pointer needs to be updated before merging.

@romainbrenguier
Copy link
Contributor Author

Now pointing to master

@tautschnig
Copy link
Collaborator

@romainbrenguier This is now failing CI.

@romainbrenguier romainbrenguier force-pushed the update-java-models-library/PR16 branch from 55521e1 to 44a46bb Compare November 26, 2018 09:09
@romainbrenguier
Copy link
Contributor Author

This is caused by the first commit diffblue/java-models-library#13 (also brought with this submodule update).
I suspect the CASE_INSENSITIVE_ORDER field.

@romainbrenguier
Copy link
Contributor Author

Superseded by #4476

@tautschnig
Copy link
Collaborator

Closing as #4476 has been merged.

@tautschnig tautschnig closed this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants