Skip to content

Correct type of bdd_cuddt::indext #4356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2019
Merged

Correct type of bdd_cuddt::indext #4356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
871c551
Correct type of bdd_cuddt::indext
romainbrenguier Mar 8, 2019
52ba6c9
Correct argument type of cudd.bddVar
romainbrenguier Mar 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/solvers/bdd/bdd_cudd.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ Author: Romain Brenguier, [email protected]

#include <cplusplus/cuddObj.hh>

#include <util/narrow.h>

class bdd_managert;
class bddt;
class bdd_nodet;
Expand All @@ -36,7 +38,7 @@ class bdd_nodet
}

/// Type of indexes of Boolean variables
using indext = int;
using indext = unsigned int;

/// Label on the node, corresponds to the index of a Boolean variable
indext index() const
Expand Down Expand Up @@ -152,7 +154,7 @@ class bdd_managert

bddt bdd_variable(bdd_nodet::indext index)
{
return bddt(cudd.bddVar(index));
return bddt(cudd.bddVar(narrow_cast<int>(index)));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need #include <util/narrow.h> to get this to build.

}

bdd_nodet bdd_node(const bddt &bdd) const
Expand Down