Correct type of bdd_cuddt::indext #4356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing errors when compiling with clang -Werror -Wsign-conversion
romainbrenguier
requested review from
chrisr-diffblue,
kroening,
peterschrammel,
smowton and
tautschnig
as code owners
allredj
reviewed
Mar 8, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 871c551).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/103720888
smowton
approved these changes
Mar 10, 2019
tautschnig
approved these changes
Mar 11, 2019
| @@ -152,7 +152,7 @@ class bdd_managert | |||
|
|
|||
| bddt bdd_variable(bdd_nodet::indext index) | |||
| { | |||
| return bddt(cudd.bddVar(index)); | |||
| return bddt(cudd.bddVar(narrow_cast<int>(index))); | |||
There was a problem hiding this comment.
You need #include <util/narrow.h> to get this to build.
The type of cudd.bddVar differs from cuddNodeReadIndex, so we need a conversion between the two.
romainbrenguier
force-pushed
the
feature/bdd-error
branch
from
8205c13 to
52ba6c9
Compare
allredj
reviewed
Mar 11, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 52ba6c9).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/103862848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing errors when compiling with clang -Werror -Wsign-conversion