Pre-contracts whitespace changes #4326
Conversation
This commit is whitespace changes to code that will be changed in a future commit. The code changes will all be fairly subtle, so this commit aims to do the whitespace changes in advance to make reviewers' lives easier.
karkhaz
requested review from
allredj,
chrisr-diffblue,
danpoe,
kroening,
martin-cs,
owen-mc-diffblue,
peterschrammel,
pkesseli,
romainbrenguier,
smowton,
tautschnig and
thk123
as code owners
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 8afda0b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/103125331
Status will be re-evaluated on next push.
Common spurious failures:
-
the cbmc commit has disappeared in the mean time (e.g. in a force-push)
-
the author is not in the list of contributors (e.g. first-time contributors).
-
the compatibility was already broken by an earlier merge.
|
@allredj would you mind helping me understand why this PR and #4213 failed compatibility checks please? I don't think it's a force-push---perhaps because I've just become a 'collaborator' rather than a 'contributor'? I'd like to be able to merge my PRs, but not sure if I should ignore these warnings. I'm not working at Diffblue, so I don't have access to travis. |
|
@karkhaz The issue is that TG was already de-synchronised from CBMC when the check was done. There doesn't seem to be anything wrong with your PR in this regard. |
I've decided to post this PR a few commits at a time, to make everybody's life easier, and so that I have a chance to actually audit the code.
This PR makes only whitespace changes. A lot of the actual code changes are quite subtle, so I'm going to get the whitespace changes out of the way first so that reviewers can focus on the code later.