Skip to content

Update compilation instructions to install jq #4213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

karkhaz
Copy link
Collaborator

@karkhaz karkhaz commented Feb 18, 2019

No description provided.

@smowton
Copy link
Contributor

smowton commented Feb 18, 2019

I'd intended jq to be a soft dependency, so it didn't hobble people only interested in cbmc -- did that not work for you? If it did, suggest noting this is optional.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: c37284f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101277070

@kroening
Copy link
Member

@smowton Many thanks for being considerate about the dependency war!
I think @karkhaz's wording is fine.

@kroening
Copy link
Member

https://xkcd.com/797/

@karkhaz
Copy link
Collaborator Author

karkhaz commented Feb 18, 2019

I could make it even more explicit, i.e.

You also need jq if you wish to run the test suite.

instead of

You also need jq to run the test suite.

will do this soon. Currently sorting out the mother of all rebase conflicts, so can't check this branch out until I'm done...

@kroening
Copy link
Member

@karkhaz Note that Chris' scripting even takes care of jq missing, i.e., you could say "You also need jq if you wish to run the entire test suite."

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: 94b66d3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/103086040
Status will be re-evaluated on next push.
Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)

  • the author is not in the list of contributors (e.g. first-time contributors).

  • the compatibility was already broken by an earlier merge.

@tautschnig tautschnig merged commit 6f3ced1 into diffblue:develop Mar 4, 2019
@karkhaz karkhaz deleted the kk-jq-install branch March 4, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants