Add test for casting after a clean or soft cast #4201
Conversation
| @@ -0,0 +1,21 @@ | |||
|
|
|||
| public class base<T> { } | |||
There was a problem hiding this comment.
Please capitalize class identifiers
There was a problem hiding this comment.
base.class (Base.class) file doesn't seem to be committed ?
smowton
force-pushed
the
smowton/cleanup/cast-base-type-test
branch
from
5136721 to
f6bbc9a
Compare
An upcast can be implemented by &child->base rather than using a typecast_exprt, but in the case of a specialised generic we may still need a cast. Check that a cast is produced when expected.
smowton
force-pushed
the
smowton/cleanup/cast-base-type-test
branch
from
f6bbc9a to
265b96b
Compare
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 5136721).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101129063
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 265b96b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101131620
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: f6bbc9a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101130945
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
This is a test for 0a3b99b, one of the type consistency fixes committed with #3822
These will get easier to express as and when
expr2javaprints generic type parameters / qualifiers, but I won't take that task on here, particularly because that means checking all consumers of pretty-printed output.