Add test for casting after a clean or soft cast

An upcast can be implemented by &child->base rather than using a typecast_exprt, but in the
case of a specialised generic we may still need a cast. Check that a cast is produced when
expected.

Author: smowton

jbmc/regression/jbmc/generic_base_type/base.class

@@ -0,0 +1,21 @@
+
+public class base<T> { }
+
+class test<T> extends base<T> {
+
+  public void main(boolean unknown) {
+
+    if(unknown)
+      callee(getSpecialisedTest());
+    else
+      callee2(getUnspecialisedTest());
+
+  }
+
+  public test<String> getSpecialisedTest() { return new test<String>(); }
+  public test<T> getUnspecialisedTest() { return new test<T>(); }
+
+  public void callee(base<String> b) { assert false; }
+  public void callee2(base<T> b) { assert false; }
+
+}

jbmc/regression/jbmc/generic_base_type/base.java

@@ -0,0 +1,10 @@
+CORE
+test.class
+--function test.main --show-goto-functions
+^EXIT=0$
+^SIGNAL=0$
+this \. test\.callee:\(Lbase;\)V\(\(struct base \*\)&return_tmp0->@base\);
+this \. test\.callee2:\(Lbase;\)V\(&return_tmp1->@base\);
+--
+callee has a qualified base type, and so requires a cast.
+callee2 has the unqualified type that test<T> naturally inherits, so no cast is required.

jbmc/regression/jbmc/generic_base_type/check_casts.desc

@@ -0,0 +1,10 @@
+CORE
+test.class
+--function test.main
+^EXIT=10$
+^SIGNAL=0$
+^VERIFICATION FAILED$
+\[java::test\.callee:\(Lbase;\)V\.assertion\.1\] line 18 assertion at file base\.java line 18 function java::test\.callee:\(Lbase;\)V bytecode-index 5: FAILURE
+\[java::test\.callee2:\(Lbase;\)V\.assertion\.1\] line 19 assertion at file base\.java line 19 function java::test\.callee2:\(Lbase;\)V bytecode-index 5: FAILURE
+--
+^warning: ignoring