Use $1 rather than \1 to refer to regex matching group #4157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least Perl 5.26 prints a warning each time; some quick Googling suggests that \n should be used on the *left* of a match-and-replace to refer to an earlier match, and $n should be used on the right, though \n is acceptable for historical reasons.
kroening
approved these changes
Feb 11, 2019
tautschnig
approved these changes
Feb 11, 2019
allredj
reviewed
Feb 11, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: d11c3f7).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100478502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least Perl 5.26 prints a warning each time; some quick Googling suggests that \n should be used
on the left of a match-and-replace to refer to an earlier match, and $n should be used on the right,
though \n is acceptable for historical reasons.